I "think" I get what you did.. you have a long bolt going from the ears of the shock to the mount on the cross member and around the bolt is a larger pipe (looks like it might be galvanized) that is used as a spacer to keep the shock from moving upwards..
that will work to keep it from going up but I don't know if the bolt that is going through the pipe is going to move around or not. If it does, it will make one heck of a racket as there are quite a bit or forces at play there..
The only way I see to verify that is the problem is to put the shock back in the cross member (no extension). If the noise goes away then you know its moving around.. Ideally, a longer shock should be used instead of that spacer since not only may the shock move around but the stress put on the cross member is going to be increased by the leveraged of the spacer.
To figure what shocks you need, measure the compressed and extended length of what you currently have. Then go to gorancho.com and look at their catalog of shocks and find a shock that has the same mounts as yours with the extended/compressed lengths you like/want. You will want to look at the back of the master catalog as that is where the shocks are listed by # instead of by application.
~Mark